Repository navigation
build(nix): add llvm-tools to the development shell - #70
Merged
Merged
Conversation
scripts/crap-report.sh runs cargo-llvm-cov, which needs the llvm-tools-preview component. The Nix shell installed only the components in rust-toolchain.toml, so the report failed there. The flake now adds llvm-tools-preview to those components. CI and rustup users still install only rust-toolchain.toml.
tee8z
added
the
no-changelog
thebrandonlucas
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
scripts/crap-report.shfailed innix developwith this error:The flake built its toolchain only from
rust-toolchain.toml, which listsrustfmtandclippyand notllvm-tools-preview.cargo-llvm-covneeds that component.Change
flake.nixreadsrust-toolchain.tomland addsllvm-tools-previewto its components. The channel and profile are still taken from that file.rust-toolchain.tomlis unchanged, so CI and rustup users do not download the component.docs/quality.md(CRAP risk check) says thatcargo-llvm-covneeds the component, that the Nix shell includes it, and how a rustup user adds it.Checks
nix develop:cargo fmt --check,cargo clippy --locked --all-targets -- -D warnings,cargo machete --with-metadata,cargo test --locked(108 unit, 91 integration) andpython3 scripts/check-coverage.pypass.rustcis 1.98.1, as pinned, and its sysroot holds the LLVM tools.src/ortests/changed. With this flake,scripts/crap-report.shran to completion on the head of feat(cli): name VOLTAGE_API_KEY and the organization source on a 403 #66: 0 of 527 measured functions at or above 20, highestwait_for_paymentat 19.60.cargo-llvm-covandknotsare still not in the flake. Install them asdocs/quality.mddescribes.no-changeloglabel is set, because the change is to development tooling and is not user-visible.